Files
query-orchestration/internal/client/update/update_test.go
T

167 lines
3.7 KiB
Go
Raw Normal View History

// Package clientupdate tests for client update functionality.
// Note: Mock-based tests have been removed. See remove_texttract_and_mocks_plan.md.
2025-04-22 19:57:35 +00:00
package clientupdate
2025-01-21 18:24:14 +00:00
import (
2025-03-05 12:05:46 +00:00
"testing"
2025-04-22 19:57:35 +00:00
"queryorchestration/internal/client"
2025-01-21 18:24:14 +00:00
"queryorchestration/internal/database/repository"
"queryorchestration/internal/serviceconfig"
2025-04-22 19:57:35 +00:00
"queryorchestration/internal/serviceconfig/queue/clientsync"
2025-06-02 10:44:45 +00:00
2025-01-21 18:24:14 +00:00
"github.com/pashagolub/pgxmock/v3"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
2025-01-21 18:24:14 +00:00
)
2025-04-22 19:57:35 +00:00
type Config struct {
serviceconfig.BaseConfig
clientsync.ClientSyncConfig
}
2025-01-21 18:24:14 +00:00
func TestUpdate(t *testing.T) {
2025-06-03 13:52:10 +00:00
ctx := t.Context()
2025-01-21 18:24:14 +00:00
pool, err := pgxmock.NewPool()
require.NoError(t, err)
2025-04-22 19:57:35 +00:00
cfg := &Config{}
cfg.DBPool = pool
cfg.DBQueries = repository.New(pool)
2025-01-21 18:24:14 +00:00
2025-04-22 19:57:35 +00:00
svc := New(cfg, &Services{
Client: client.New(cfg),
})
2025-01-21 18:24:14 +00:00
2025-04-22 19:57:35 +00:00
c := client.Client{
ID: "huhu",
2025-01-21 18:24:14 +00:00
Name: "example_name",
CanSync: false,
}
update := Update{}
2025-01-21 18:24:14 +00:00
pool.ExpectQuery("name: GetClient :one").WithArgs(c.ID).
2025-01-21 18:24:14 +00:00
WillReturnRows(
pgxmock.NewRows([]string{"id", "name", "canSync"}).
AddRow(c.ID, c.Name, c.CanSync),
2025-01-21 18:24:14 +00:00
)
err = svc.Update(ctx, c.ID, &update)
assert.Error(t, err)
2025-01-21 18:24:14 +00:00
c.CanSync = false
update.CanSync = &c.CanSync
pool.ExpectQuery("name: GetClient :one").WithArgs(c.ID).
2025-01-21 18:24:14 +00:00
WillReturnRows(
pgxmock.NewRows([]string{"id", "name", "canSync"}).
AddRow(c.ID, c.Name, c.CanSync),
2025-01-21 18:24:14 +00:00
)
err = svc.Update(ctx, c.ID, &update)
assert.Error(t, err)
2025-01-21 18:24:14 +00:00
c.Name = "updated_name"
update.Name = &c.Name
pool.ExpectQuery("name: GetClient :one").WithArgs(c.ID).
2025-01-21 18:24:14 +00:00
WillReturnRows(
pgxmock.NewRows([]string{"id", "name", "canSync"}).
AddRow(c.ID, c.Name, c.CanSync),
2025-01-21 18:24:14 +00:00
)
pool.ExpectExec("name: UpdateClient :exec").WithArgs(*update.Name, c.ID).
2025-01-21 18:24:14 +00:00
WillReturnResult(pgxmock.NewResult("", 1))
err = svc.Update(ctx, c.ID, &update)
assert.Error(t, err)
}
func TestNormalizeUpdateParams(t *testing.T) {
svc := Service{}
err := svc.normalizeUpdateParams("huhu", nil, nil)
assert.Error(t, err)
2025-04-22 19:57:35 +00:00
current := &client.Client{
ID: "hi",
Name: "client",
}
update := &Update{}
err = svc.normalizeUpdateParams(current.ID, current, update)
assert.Error(t, err)
n := "updated_client"
cs := true
update = &Update{
Name: &n,
CanSync: &cs,
}
err = svc.normalizeUpdateParams(current.ID, current, update)
2025-03-19 11:54:14 +00:00
require.NoError(t, err)
n = "updated_client"
cs = true
assert.EqualExportedValues(t, Update{
Name: &n,
CanSync: &cs,
}, *update)
update = &Update{
Name: &current.Name,
CanSync: &current.CanSync,
}
err = svc.normalizeUpdateParams(current.ID, current, update)
assert.Error(t, err)
}
func TestSubmitUpdate(t *testing.T) {
2025-06-03 13:52:10 +00:00
ctx := t.Context()
pool, err := pgxmock.NewPool()
require.NoError(t, err)
2025-04-22 19:57:35 +00:00
cfg := &Config{}
cfg.DBPool = pool
cfg.DBQueries = repository.New(pool)
2025-04-22 19:57:35 +00:00
svc := New(cfg, &Services{})
2025-04-22 19:57:35 +00:00
c := client.Client{
ID: "hello",
Name: "example_name",
CanSync: false,
}
update := Update{}
pool.ExpectBegin()
pool.ExpectCommit()
err = svc.submitUpdate(ctx, c.ID, &update)
2025-03-19 11:54:14 +00:00
require.NoError(t, err)
c.CanSync = true
update.CanSync = &c.CanSync
pool.ExpectBegin()
pool.ExpectExec("name: AddClientCanSync :exec").WithArgs(*update.CanSync, c.ID).
WillReturnResult(pgxmock.NewResult("", 1))
pool.ExpectCommit()
err = svc.submitUpdate(ctx, c.ID, &update)
2025-03-19 11:54:14 +00:00
require.NoError(t, err)
c.Name = "updated_name"
update.Name = &c.Name
update.CanSync = nil
pool.ExpectBegin()
pool.ExpectExec("name: UpdateClient :exec").WithArgs(*update.Name, c.ID).
WillReturnResult(pgxmock.NewResult("", 1))
pool.ExpectCommit()
err = svc.submitUpdate(ctx, c.ID, &update)
2025-03-19 11:54:14 +00:00
require.NoError(t, err)
2025-01-21 18:24:14 +00:00
}
2025-04-22 19:57:35 +00:00
// Note: TestInformUpdate was removed as it used SQS mocks.
// Real SQS tests should be added using LocalStack via testcontainers.