Merged in bugfix/tests (pull request #107)
Fix Fullsuite * save * foundthefix.. * codeandrequire
This commit is contained in:
@@ -53,17 +53,17 @@ type S3EventRecord struct {
|
||||
EventSource string `json:"eventSource"`
|
||||
AwsRegion string `json:"awsRegion"`
|
||||
EventTime string `json:"eventTime"`
|
||||
EventName string `json:"eventName"`
|
||||
EventName EventS3 `json:"eventName"`
|
||||
S3 S3EventRecordDetails `json:"s3"`
|
||||
}
|
||||
type S3EventNotification struct {
|
||||
Records []S3EventRecord `json:"Records"`
|
||||
}
|
||||
|
||||
type S3Events string
|
||||
type EventS3 string
|
||||
|
||||
const (
|
||||
S3EventObjectCreatedPut = "ObjectCreated:Put"
|
||||
EventS3ObjectCreatedPut = "ObjectCreated:Put"
|
||||
)
|
||||
|
||||
func (s Runner) Process(ctx context.Context, req *types.Message) bool {
|
||||
@@ -118,6 +118,6 @@ func (s Runner) processRecord(ctx context.Context, record S3EventRecord) error {
|
||||
return nil
|
||||
}
|
||||
|
||||
func (s Runner) isSupportedEvent(name string) bool {
|
||||
return name == S3EventObjectCreatedPut
|
||||
func (s Runner) isSupportedEvent(name EventS3) bool {
|
||||
return name == EventS3ObjectCreatedPut
|
||||
}
|
||||
|
||||
@@ -59,7 +59,7 @@ func TestDocInitRunner(t *testing.T) {
|
||||
doc := S3EventNotification{
|
||||
Records: []S3EventRecord{
|
||||
{
|
||||
EventName: "ObjectCreated:Put",
|
||||
EventName: EventS3ObjectCreatedPut,
|
||||
S3: S3EventRecordDetails{
|
||||
Bucket: S3Bucket{
|
||||
Name: bucketName,
|
||||
@@ -73,7 +73,7 @@ func TestDocInitRunner(t *testing.T) {
|
||||
},
|
||||
}
|
||||
bodyBytes, err := json.Marshal(doc)
|
||||
assert.NoError(t, err)
|
||||
require.NoError(t, err)
|
||||
body := string(bodyBytes)
|
||||
msg := &types.Message{
|
||||
Body: &body,
|
||||
@@ -150,7 +150,7 @@ func TestProcessRecord(t *testing.T) {
|
||||
Hash: "example_hash",
|
||||
}
|
||||
record := S3EventRecord{
|
||||
EventName: S3EventObjectCreatedPut,
|
||||
EventName: EventS3ObjectCreatedPut,
|
||||
S3: S3EventRecordDetails{
|
||||
Bucket: S3Bucket{
|
||||
Name: bucketName,
|
||||
@@ -191,7 +191,7 @@ func TestProcessRecord(t *testing.T) {
|
||||
Return(&sqs.SendMessageOutput{}, nil)
|
||||
|
||||
err = runner.processRecord(ctx, record)
|
||||
assert.NoError(t, err)
|
||||
require.NoError(t, err)
|
||||
})
|
||||
t.Run("invalid_event", func(t *testing.T) {
|
||||
record := S3EventRecord{
|
||||
@@ -199,12 +199,12 @@ func TestProcessRecord(t *testing.T) {
|
||||
}
|
||||
|
||||
err = runner.processRecord(ctx, record)
|
||||
assert.NoError(t, err)
|
||||
require.NoError(t, err)
|
||||
})
|
||||
t.Run("invalid id", func(t *testing.T) {
|
||||
location := "cc/aaa"
|
||||
record := S3EventRecord{
|
||||
EventName: S3EventObjectCreatedPut,
|
||||
EventName: EventS3ObjectCreatedPut,
|
||||
S3: S3EventRecordDetails{
|
||||
Object: S3Object{
|
||||
Key: location,
|
||||
@@ -213,7 +213,7 @@ func TestProcessRecord(t *testing.T) {
|
||||
}
|
||||
|
||||
err = runner.processRecord(ctx, record)
|
||||
assert.NoError(t, err)
|
||||
require.NoError(t, err)
|
||||
})
|
||||
}
|
||||
|
||||
@@ -221,7 +221,7 @@ func TestIsSupportedEvent(t *testing.T) {
|
||||
runner := Runner{}
|
||||
|
||||
t.Run("put", func(t *testing.T) {
|
||||
assert.True(t, runner.isSupportedEvent(S3EventObjectCreatedPut))
|
||||
assert.True(t, runner.isSupportedEvent(EventS3ObjectCreatedPut))
|
||||
})
|
||||
t.Run("invalid", func(t *testing.T) {
|
||||
assert.False(t, runner.isSupportedEvent("invalid"))
|
||||
|
||||
Reference in New Issue
Block a user