Merged in bugfix/tests (pull request #107)

Fix Fullsuite

* save

* foundthefix..

* codeandrequire

internal/client/create_test.go

@@ -38,7 +38,7 @@ func TestCreate(t *testing.T) {
 		)
 
 	id, err := svc.Create(ctx, params)
-	assert.NoError(t, err)
+	require.NoError(t, err)
 	assert.Equal(t, aid, id)
 }
 
@@ -54,7 +54,7 @@ func TestNormalizeCreate(t *testing.T) {
 		}
 
 		err := svc.normalizeCreate(params)
-		assert.NoError(t, err)
+		require.NoError(t, err)
 		assert.Equal(t, "client_name", params.Name)
 		assert.Equal(t, "external_id", params.ExternalId)
 	})
@@ -65,7 +65,7 @@ func TestNormalizeCreate(t *testing.T) {
 		}
 
 		err := svc.normalizeCreate(params)
-		assert.NoError(t, err)
+		require.NoError(t, err)
 		assert.Equal(t, "client_name", params.Name)
 		assert.Equal(t, "external_id", params.ExternalId)
 	})

internal/client/get_test.go

@@ -35,7 +35,7 @@ func TestGet(t *testing.T) {
 		)
 
 	cli, err := svc.Get(ctx, id)
-	assert.NoError(t, err)
+	require.NoError(t, err)
 	assert.EqualExportedValues(t, &Client{
 		ID:         id,
 		ExternalID: "client_id",
@@ -72,7 +72,7 @@ func TestGetByExternalId(t *testing.T) {
 		)
 
 	cli, err := svc.GetByExternalId(ctx, externalId)
-	assert.NoError(t, err)
+	require.NoError(t, err)
 	assert.EqualExportedValues(t, &Client{
 		ID:         id,
 		ExternalID: "client_id",

internal/client/serviceprivate_test.go

@@ -5,6 +5,7 @@ import (
 
 	"github.com/google/uuid"
 	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
 )
 
 func TestNormalizeName(t *testing.T) {
@@ -24,7 +25,7 @@ func TestNormalizeName(t *testing.T) {
 	}
 	for key, value := range names {
 		err := normalizeName(&key)
-		assert.NoError(t, err)
+		require.NoError(t, err)
 		assert.Equal(t, value, key)
 	}
 
@@ -62,19 +63,19 @@ func TestNormalizeNameUpdate(t *testing.T) {
 	}
 
 	err := c.normalizeNameUpdate(nil)
-	assert.NoError(t, err)
+	require.NoError(t, err)
 
 	v := "update_name"
 	val := &v
 	err = c.normalizeNameUpdate(&val)
-	assert.NoError(t, err)
+	require.NoError(t, err)
 	assert.NotNil(t, val)
 	assert.Equal(t, "update_name", *val)
 
 	v = c.Name
 	val = &v
 	err = c.normalizeNameUpdate(&val)
-	assert.NoError(t, err)
+	require.NoError(t, err)
 	assert.Nil(t, val)
 
 	v = "###"

internal/client/status_test.go

@@ -41,7 +41,7 @@ func TestGetStatusByExternalId(t *testing.T) {
 		)
 
 		issynced, err := svc.GetStatusByExternalId(ctx, externalId)
-		assert.NoError(t, err)
+		require.NoError(t, err)
 		assert.Equal(t, client.IN_SYNC, issynced)
 	})
 	t.Run("not synced", func(t *testing.T) {
@@ -55,7 +55,7 @@ func TestGetStatusByExternalId(t *testing.T) {
 		)
 
 		issynced, err := svc.GetStatusByExternalId(ctx, externalId)
-		assert.NoError(t, err)
+		require.NoError(t, err)
 		assert.Equal(t, client.NOT_SYNCED, issynced)
 	})
 	t.Run("not syncing", func(t *testing.T) {
@@ -65,7 +65,7 @@ func TestGetStatusByExternalId(t *testing.T) {
 		)
 
 		issynced, err := svc.GetStatusByExternalId(ctx, externalId)
-		assert.NoError(t, err)
+		require.NoError(t, err)
 		assert.Equal(t, client.NOT_SYNCING, issynced)
 	})
 	t.Run("db error", func(t *testing.T) {

internal/client/sync/sync_test.go

@@ -15,7 +15,6 @@ import (
 	"github.com/aws/aws-sdk-go-v2/service/sqs"
 	"github.com/google/uuid"
 	"github.com/pashagolub/pgxmock/v3"
-	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/mock"
 	"github.com/stretchr/testify/require"
 )
@@ -85,7 +84,7 @@ func TestTrigger(t *testing.T) {
 			Return(&sqs.SendMessageOutput{}, nil)
 
 		err = svc.Sync(ctx, clientId)
-		assert.NoError(t, err)
+		require.NoError(t, err)
 	})
 	t.Run("empty batch", func(t *testing.T) {
 		ctx := context.Background()
@@ -111,6 +110,6 @@ func TestTrigger(t *testing.T) {
 			)
 
 		err = svc.Sync(ctx, clientId)
-		assert.NoError(t, err)
+		require.NoError(t, err)
 	})
 }

internal/client/update_test.go

@@ -90,7 +90,7 @@ func TestNormalizeUpdateParams(t *testing.T) {
 		CanSync: &cs,
 	}
 	err = svc.normalizeUpdateParams(current.ID, current, update)
-	assert.NoError(t, err)
+	require.NoError(t, err)
 	n = "updated_client"
 	cs = true
 	assert.EqualExportedValues(t, Update{
@@ -128,7 +128,7 @@ func TestSubmitUpdate(t *testing.T) {
 	pool.ExpectCommit()
 
 	err = svc.submitUpdate(ctx, c.ID, &update)
-	assert.NoError(t, err)
+	require.NoError(t, err)
 
 	c.CanSync = true
 	update.CanSync = &c.CanSync
@@ -139,7 +139,7 @@ func TestSubmitUpdate(t *testing.T) {
 	pool.ExpectCommit()
 
 	err = svc.submitUpdate(ctx, c.ID, &update)
-	assert.NoError(t, err)
+	require.NoError(t, err)
 
 	c.Name = "updated_name"
 	update.Name = &c.Name
@@ -151,7 +151,7 @@ func TestSubmitUpdate(t *testing.T) {
 	pool.ExpectCommit()
 
 	err = svc.submitUpdate(ctx, c.ID, &update)
-	assert.NoError(t, err)
+	require.NoError(t, err)
 }
 
 func TestUpdateByExternalId(t *testing.T) {