Merged in feature/clientexternalid (pull request #99)

Client External ID

* normalizeexternalid

* cleanopenapi

* cleanopenapi

* changingpublic

* noprecommit

* testing

* precommit

* processtest

* nodb

* tests

* tests

internal/client/serviceprivate_test.go

@@ -8,44 +8,29 @@ import (
 )
 
 func TestNormalizeName(t *testing.T) {
-	name := "name"
+	names := map[string]string{
+		"name":                 "name",
+		"   name\t":            "name",
+		"name second":          "name second",
+		"name\t second":        "name second",
+		"name_second":          "name_second",
+		"name-second":          "name-second",
+		"name123":              "name123",
+		"Name One - Two":       "Name One - Two",
+		"Name, Inc.":           "Name, Inc.",
+		"Namer - Two":          "Namer - Two",
+		"Name (Hello One)":     "Name (Hello One)",
+		"Name (Hello One) Bye": "Name (Hello One) Bye",
+	}
+	for key, value := range names {
+		err := normalizeName(&key)
+		assert.NoError(t, err)
+		assert.Equal(t, value, key)
+	}
+
+	name := ""
 	err := normalizeName(&name)
-	assert.NoError(t, err)
-	assert.Equal(t, "name", name)
-
-	name = ""
-	err = normalizeName(&name)
 	assert.Error(t, err)
-
-	name = "   name\t"
-	err = normalizeName(&name)
-	assert.NoError(t, err)
-	assert.Equal(t, "name", name)
-
-	name = "name second"
-	err = normalizeName(&name)
-	assert.NoError(t, err)
-	assert.Equal(t, "name second", name)
-
-	name = "name\t second"
-	err = normalizeName(&name)
-	assert.NoError(t, err)
-	assert.Equal(t, "name second", name)
-
-	name = "name_second"
-	err = normalizeName(&name)
-	assert.NoError(t, err)
-	assert.Equal(t, "name_second", name)
-
-	name = "name-second"
-	err = normalizeName(&name)
-	assert.NoError(t, err)
-	assert.Equal(t, "name-second", name)
-
-	name = "name123"
-	err = normalizeName(&name)
-	assert.NoError(t, err)
-	assert.Equal(t, "name123", name)
 }
 
 func TestNormalizeCanSyncUpdate(t *testing.T) {