Merged in bugfix/errhandling (pull request #89)

Error handling * basic
2025-03-05 19:49:03 +00:00
parent c78ca26a6f
commit 8f409e60a8
36 changed files with 965 additions and 641 deletions
@@ -49,47 +49,58 @@ func TestQueryRunner(t *testing.T) {
 	})
 	assert.NotNil(t, runner)

-	doc := queryversionsyncrunner.Body{
-		ID: uuid.New(),
-	}
-	bodyBytes, err := json.Marshal(doc)
-	assert.NoError(t, err)
-	body := string(bodyBytes)
-	msg := &types.Message{
-		Body: &body,
-	}
+	t.Run("valid", func(t *testing.T) {
+		doc := queryversionsyncrunner.Body{
+			ID: uuid.New(),
+		}
+		bodyBytes, err := json.Marshal(doc)
+		assert.NoError(t, err)
+		body := string(bodyBytes)
+		msg := &types.Message{
+			Body: &body,
+		}

-	jobIds := []uuid.UUID{
-		uuid.New(),
-		uuid.New(),
-	}
+		jobIds := []uuid.UUID{
+			uuid.New(),
+			uuid.New(),
+		}

-	pool.ExpectQuery("name: ListQueryJobIDs :many").WithArgs(database.MustToDBUUID(doc.ID)).
-		WillReturnRows(
-			pgxmock.NewRows([]string{"jobId"}).
-				AddRow(database.MustToDBUUID(jobIds[0])).
-				AddRow(database.MustToDBUUID(jobIds[1])),
-		)
+		pool.ExpectQuery("name: ListQueryJobIDs :many").WithArgs(database.MustToDBUUID(doc.ID)).
+			WillReturnRows(
+				pgxmock.NewRows([]string{"jobId"}).
+					AddRow(database.MustToDBUUID(jobIds[0])).
+					AddRow(database.MustToDBUUID(jobIds[1])),
+			)

-	mockSQS.EXPECT().
-		SendMessage(
-			mock.Anything,
-			mock.MatchedBy(func(in *sqs.SendMessageInput) bool {
-				return *in.QueueUrl == cfg.JobSyncURL && *in.MessageBody == fmt.Sprintf("{\"id\":\"%s\"}", jobIds[0].String())
-			}),
-			mock.Anything,
-		).
-		Return(&sqs.SendMessageOutput{}, nil)
-	mockSQS.EXPECT().
-		SendMessage(
-			mock.Anything,
-			mock.MatchedBy(func(in *sqs.SendMessageInput) bool {
-				return *in.QueueUrl == cfg.JobSyncURL && *in.MessageBody == fmt.Sprintf("{\"id\":\"%s\"}", jobIds[1].String())
-			}),
-			mock.Anything,
-		).
-		Return(&sqs.SendMessageOutput{}, nil)
+		mockSQS.EXPECT().
+			SendMessage(
+				mock.Anything,
+				mock.MatchedBy(func(in *sqs.SendMessageInput) bool {
+					return *in.QueueUrl == cfg.JobSyncURL && *in.MessageBody == fmt.Sprintf("{\"id\":\"%s\"}", jobIds[0].String())
+				}),
+				mock.Anything,
+			).
+			Return(&sqs.SendMessageOutput{}, nil)
+		mockSQS.EXPECT().
+			SendMessage(
+				mock.Anything,
+				mock.MatchedBy(func(in *sqs.SendMessageInput) bool {
+					return *in.QueueUrl == cfg.JobSyncURL && *in.MessageBody == fmt.Sprintf("{\"id\":\"%s\"}", jobIds[1].String())
+				}),
+				mock.Anything,
+			).
+			Return(&sqs.SendMessageOutput{}, nil)

-	err = runner.Process(ctx, msg)
-	assert.NoError(t, err)
+		assert.True(t, runner.Process(ctx, msg))
+	})
+	t.Run("invalid body", func(t *testing.T) {
+		body := "definitely invalid"
+		msgId := "id"
+		msg := &types.Message{
+			Body:      &body,
+			MessageId: &msgId,
+		}
+
+		assert.True(t, runner.Process(ctx, msg))
+	})
 }