From a9d81a10943977ed9a874128a2ab9108e80bbc4b Mon Sep 17 00:00:00 2001 From: jay brown Date: Tue, 22 Jul 2025 10:29:44 -0700 Subject: [PATCH] remove parallel remove parallel to stabilize ci/cd --- .golangci.yml | 5 +---- api/clientSyncRunner/runner_test.go | 1 - api/docCleanRunner/runner_test.go | 1 - api/docInitRunner/runner_test.go | 1 - api/docSyncRunner/runner_test.go | 1 - api/docTextRunner/runner_test.go | 1 - api/queryAPI/client_test.go | 3 --- api/queryAPI/collector_test.go | 2 -- api/queryAPI/documents_test.go | 3 --- api/queryAPI/query_test.go | 5 ----- api/queryAPI/status_test.go | 1 - internal/server/api/listener_test.go | 1 - internal/test/mockserver_test.go | 1 - internal/test/objectstore_test.go | 1 - internal/test/queue_test.go | 4 ---- test/process_test.go | 3 --- test/queryAPI/accessory_test.go | 1 - test/queryAPI/client_test.go | 1 - test/queryAPI/collectorservice_test.go | 1 - test/queryAPI/queryservice_test.go | 4 ---- 20 files changed, 1 insertion(+), 40 deletions(-) diff --git a/.golangci.yml b/.golangci.yml index 1b701cb3..38325089 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -17,7 +17,7 @@ linters: - cyclop - unused - usetesting - - paralleltest + # - paralleltest # Disabled to prevent race conditions in CI - bodyclose # Check HTTP response bodies are closed - gochecknoinits # Disallow `init` functions # - gocritic # Advanced style/performance checks @@ -55,9 +55,6 @@ linters-settings: issues: exclude-rules: - - path-except: ^test/ - linters: - - paralleltest - path: cmd/metricsExample_test/main\.go linters: - gosec diff --git a/api/clientSyncRunner/runner_test.go b/api/clientSyncRunner/runner_test.go index 907e2064..7898fd12 100644 --- a/api/clientSyncRunner/runner_test.go +++ b/api/clientSyncRunner/runner_test.go @@ -26,7 +26,6 @@ type ClientSyncConfig struct { } func TestClientSyncRunner(t *testing.T) { - t.Parallel() cfg := &ClientSyncConfig{} test.CreateDB(t, cfg) acfg := test.CreateAWSContainer(t, cfg) diff --git a/api/docCleanRunner/runner_test.go b/api/docCleanRunner/runner_test.go index de2df002..f08ed34c 100644 --- a/api/docCleanRunner/runner_test.go +++ b/api/docCleanRunner/runner_test.go @@ -31,7 +31,6 @@ type DocCleanConfig struct { } func TestDocCleanRunner(t *testing.T) { - t.Parallel() cfg := &DocCleanConfig{} test.CreateDB(t, cfg) acfg := test.CreateAWSContainer(t, cfg) diff --git a/api/docInitRunner/runner_test.go b/api/docInitRunner/runner_test.go index d940d07c..ebeb850d 100644 --- a/api/docInitRunner/runner_test.go +++ b/api/docInitRunner/runner_test.go @@ -26,7 +26,6 @@ type DocInitConfig struct { } func TestDocInitRunner(t *testing.T) { - t.Parallel() cfg := &DocInitConfig{} test.CreateDB(t, cfg) acfg := test.CreateAWSContainer(t, cfg) diff --git a/api/docSyncRunner/runner_test.go b/api/docSyncRunner/runner_test.go index ba263537..dc7a9346 100644 --- a/api/docSyncRunner/runner_test.go +++ b/api/docSyncRunner/runner_test.go @@ -30,7 +30,6 @@ type DocSyncConfig struct { } func TestDocSyncRunner(t *testing.T) { - t.Parallel() cfg := &DocSyncConfig{} test.CreateDB(t, cfg) acfg := test.CreateAWSContainer(t, cfg) diff --git a/api/docTextRunner/runner_test.go b/api/docTextRunner/runner_test.go index 903d498f..8ca6444e 100644 --- a/api/docTextRunner/runner_test.go +++ b/api/docTextRunner/runner_test.go @@ -37,7 +37,6 @@ type DocTextConfig struct { } func TestDocTextRunner(t *testing.T) { - t.Parallel() cfg := &DocTextConfig{} test.CreateDB(t, cfg) acfg := test.CreateAWSContainer(t, cfg) diff --git a/api/queryAPI/client_test.go b/api/queryAPI/client_test.go index f69c34a4..99edd7cf 100644 --- a/api/queryAPI/client_test.go +++ b/api/queryAPI/client_test.go @@ -18,7 +18,6 @@ import ( ) func TestCreateClient(t *testing.T) { - t.Parallel() cfg := &ControllerConfig{} test.CreateDB(t, cfg) initializeTestConfig(t, cfg) @@ -47,7 +46,6 @@ func TestCreateClient(t *testing.T) { } func TestGetClient(t *testing.T) { - t.Parallel() cfg := &ControllerConfig{} test.CreateDB(t, cfg) initializeTestConfig(t, cfg) @@ -81,7 +79,6 @@ func TestGetClient(t *testing.T) { } func TestUpdateClient(t *testing.T) { - t.Parallel() cfg := &ControllerConfig{} test.CreateDB(t, cfg) initializeTestConfig(t, cfg) diff --git a/api/queryAPI/collector_test.go b/api/queryAPI/collector_test.go index 48d45b58..6608dc78 100644 --- a/api/queryAPI/collector_test.go +++ b/api/queryAPI/collector_test.go @@ -15,7 +15,6 @@ import ( ) func TestSetCollector(t *testing.T) { - t.Parallel() cfg := &ControllerConfig{} test.CreateDB(t, cfg) initializeTestConfig(t, cfg) @@ -60,7 +59,6 @@ func TestSetCollector(t *testing.T) { } func TestGetCollectorByClientId(t *testing.T) { - t.Parallel() cfg := &ControllerConfig{} test.CreateDB(t, cfg) initializeTestConfig(t, cfg) diff --git a/api/queryAPI/documents_test.go b/api/queryAPI/documents_test.go index b1aff40f..d4b4a8b5 100644 --- a/api/queryAPI/documents_test.go +++ b/api/queryAPI/documents_test.go @@ -17,7 +17,6 @@ import ( ) func TestUploadDocument(t *testing.T) { - t.Parallel() cfg := &ControllerConfig{} test.CreateDB(t, cfg) initializeTestConfig(t, cfg) @@ -57,7 +56,6 @@ func TestUploadDocument(t *testing.T) { } func TestListDocumentsByClientId(t *testing.T) { - t.Parallel() cfg := &ControllerConfig{} test.CreateDB(t, cfg) initializeTestConfig(t, cfg) @@ -90,7 +88,6 @@ func TestListDocumentsByClientId(t *testing.T) { } func TestGetDocument(t *testing.T) { - t.Parallel() cfg := &ControllerConfig{} test.CreateDB(t, cfg) initializeTestConfig(t, cfg) diff --git a/api/queryAPI/query_test.go b/api/queryAPI/query_test.go index bd00b6c0..219f8550 100644 --- a/api/queryAPI/query_test.go +++ b/api/queryAPI/query_test.go @@ -41,7 +41,6 @@ import ( ) func TestCreateQuery(t *testing.T) { - t.Parallel() cfg := &ControllerConfig{} test.CreateDB(t, cfg) initializeTestConfig(t, cfg) @@ -62,7 +61,6 @@ func TestCreateQuery(t *testing.T) { } func TestListQueries(t *testing.T) { - t.Parallel() cfg := &ControllerConfig{} test.CreateDB(t, cfg) initializeTestConfig(t, cfg) @@ -91,7 +89,6 @@ func TestListQueries(t *testing.T) { } func TestGetQuery(t *testing.T) { - t.Parallel() cfg := &ControllerConfig{} test.CreateDB(t, cfg) initializeTestConfig(t, cfg) @@ -116,7 +113,6 @@ func TestGetQuery(t *testing.T) { } func TestUpdateQuery(t *testing.T) { - t.Parallel() cfg := &ControllerConfig{} test.CreateDB(t, cfg) initializeTestConfig(t, cfg) @@ -230,7 +226,6 @@ func createDocumentWithText(t testing.TB, cfg *ControllerConfig, clientId string } func TestTestQuery(t *testing.T) { - t.Parallel() cfg := &ControllerConfig{} test.CreateDB(t, cfg) initializeTestConfig(t, cfg) diff --git a/api/queryAPI/status_test.go b/api/queryAPI/status_test.go index 00c4a1ce..b8383ba1 100644 --- a/api/queryAPI/status_test.go +++ b/api/queryAPI/status_test.go @@ -13,7 +13,6 @@ import ( ) func TestGetClientStatus(t *testing.T) { - t.Parallel() cfg := &ControllerConfig{} test.CreateDB(t, cfg) initializeTestConfig(t, cfg) diff --git a/internal/server/api/listener_test.go b/internal/server/api/listener_test.go index 69151226..c08c62a7 100644 --- a/internal/server/api/listener_test.go +++ b/internal/server/api/listener_test.go @@ -22,7 +22,6 @@ func TestNewAPI(t *testing.T) { if testing.Short() { t.SkipNow() } - t.Parallel() ctx := t.Context() cfg := &BaseConfig{} diff --git a/internal/test/mockserver_test.go b/internal/test/mockserver_test.go index 4ea548b4..e59bed86 100644 --- a/internal/test/mockserver_test.go +++ b/internal/test/mockserver_test.go @@ -51,7 +51,6 @@ func TestCreateDetectDocumentTextExpectation(t *testing.T) { } func TestWaitForMockEndpoint(t *testing.T) { - t.Parallel() if testing.Short() { t.SkipNow() } diff --git a/internal/test/objectstore_test.go b/internal/test/objectstore_test.go index af40ca4a..df8d793b 100644 --- a/internal/test/objectstore_test.go +++ b/internal/test/objectstore_test.go @@ -21,7 +21,6 @@ type StoreConfig struct { } func TestCreateBucket(t *testing.T) { - t.Parallel() if testing.Short() { t.SkipNow() } diff --git a/internal/test/queue_test.go b/internal/test/queue_test.go index 316c0d73..dfdc51c0 100644 --- a/internal/test/queue_test.go +++ b/internal/test/queue_test.go @@ -22,7 +22,6 @@ type TestConfig struct { } func TestCreateQueue(t *testing.T) { - t.Parallel() if testing.Short() { t.SkipNow() } @@ -38,7 +37,6 @@ func TestCreateQueue(t *testing.T) { } func TestAssertMessageWait(t *testing.T) { - t.Parallel() if testing.Short() { t.SkipNow() } @@ -63,7 +61,6 @@ func TestAssertMessageWait(t *testing.T) { } func TestAssertMessageBodyWait(t *testing.T) { - t.Parallel() if testing.Short() { t.SkipNow() } @@ -85,7 +82,6 @@ func TestAssertMessageBodyWait(t *testing.T) { } func TestAssertMessageAttrWait(t *testing.T) { - t.Parallel() if testing.Short() { t.SkipNow() } diff --git a/test/process_test.go b/test/process_test.go index c03cd5b2..8e9d5c3c 100644 --- a/test/process_test.go +++ b/test/process_test.go @@ -24,7 +24,6 @@ type Config struct { func TestProcess(t *testing.T) { t.Run("basic upload", func(t *testing.T) { - t.Parallel() cfg := &Config{} net, clean := test.CreateFullNetwork(t, t.Context(), cfg) @@ -95,7 +94,6 @@ func TestProcess(t *testing.T) { assert.EqualExportedValues(t, expectedDoc, *docRes.JSON200) }) t.Run("update config", func(t *testing.T) { - t.Parallel() cfg := &Config{} net, clean := test.CreateFullNetwork(t, t.Context(), cfg) @@ -176,7 +174,6 @@ func TestProcess(t *testing.T) { assert.EqualExportedValues(t, expectedDoc, *docRes.JSON200) }) t.Run("test multiple versions", func(t *testing.T) { - t.Parallel() cfg := &Config{} net, clean := test.CreateFullNetwork(t, t.Context(), cfg) diff --git a/test/queryAPI/accessory_test.go b/test/queryAPI/accessory_test.go index 518e8ce0..e1eb139a 100644 --- a/test/queryAPI/accessory_test.go +++ b/test/queryAPI/accessory_test.go @@ -13,7 +13,6 @@ import ( ) func TestQueryAPIAccessories(t *testing.T) { - t.Parallel() ctx := t.Context() cfg := &Config{} diff --git a/test/queryAPI/client_test.go b/test/queryAPI/client_test.go index 06d99558..22db02f5 100644 --- a/test/queryAPI/client_test.go +++ b/test/queryAPI/client_test.go @@ -12,7 +12,6 @@ import ( ) func TestClient(t *testing.T) { - t.Parallel() ctx := t.Context() cfg := &Config{} diff --git a/test/queryAPI/collectorservice_test.go b/test/queryAPI/collectorservice_test.go index 9cb77f74..fe26dead 100644 --- a/test/queryAPI/collectorservice_test.go +++ b/test/queryAPI/collectorservice_test.go @@ -26,7 +26,6 @@ type Config struct { } func TestCollectorService(t *testing.T) { - t.Parallel() ctx := t.Context() cfg := &Config{} diff --git a/test/queryAPI/queryservice_test.go b/test/queryAPI/queryservice_test.go index b78d7db0..9eba1a8b 100644 --- a/test/queryAPI/queryservice_test.go +++ b/test/queryAPI/queryservice_test.go @@ -15,7 +15,6 @@ import ( func TestQueryAPI(t *testing.T) { t.Run("list no queries", func(t *testing.T) { - t.Parallel() cfg := &Config{} c, cleanup := test.CreateAPINetworkWithParams(t, cfg, test.QueryAPI, &test.FullDependenciesParams{ @@ -32,7 +31,6 @@ func TestQueryAPI(t *testing.T) { assert.Len(t, queriesRes.JSON200.Queries, 0) }) t.Run("create and get query", func(t *testing.T) { - t.Parallel() ctx := t.Context() cfg := &Config{} @@ -71,7 +69,6 @@ func TestQueryAPI(t *testing.T) { assert.Equal(t, jcfg, *queriesRes.JSON200.Queries[0].Config) }) t.Run("update query", func(t *testing.T) { - t.Parallel() ctx := t.Context() cfg := &Config{} @@ -116,7 +113,6 @@ func TestQueryAPI(t *testing.T) { assert.Nil(t, queryRes.JSON200.RequiredQueries) }) t.Run("multiple dependent queries", func(t *testing.T) { - t.Parallel() ctx := t.Context() cfg := &Config{}