query-orchestration/internal/job/collector/update/updateprivate_test.go

package collectorupdate

import (
	"context"
	"fmt"
	"queryorchestration/internal/database"
	"queryorchestration/internal/database/repository"
	cleanversion "queryorchestration/internal/document/clean/version"
	textversion "queryorchestration/internal/document/text/version"
	"queryorchestration/internal/job/collector"
	"queryorchestration/internal/serviceconfig"
	"queryorchestration/internal/serviceconfig/queue/jobsync"
	queuemock "queryorchestration/mocks/queue"
	"testing"

	"github.com/aws/aws-sdk-go-v2/service/sqs"
	"github.com/google/uuid"
	"github.com/jackc/pgx/v5"
	"github.com/jackc/pgx/v5/pgtype"
	"github.com/pashagolub/pgxmock/v3"
	"github.com/stretchr/testify/assert"
	"github.com/stretchr/testify/mock"
)

type CollectorUpdateConfig struct {
	serviceconfig.BaseConfig
	jobsync.JobSyncConfig
}

func TestGetUpdateParams(t *testing.T) {
	t.Run("all params", func(t *testing.T) {
		ctx := context.Background()

		pool, err := pgxmock.NewPool()
		if err != nil {
			t.Fatalf("failed to open pgxmock database: %v", err)
		}
		cfg := &CollectorUpdateConfig{}
		cfg.DBPool = pool
		cfg.DBQueries = repository.New(pool)

		svc := Service{
			cfg: cfg,
			svc: &Services{
				Collector: collector.New(cfg, &collector.Services{}),
			},
		}

		minCleanV := int32(1)
		minTextV := int32(1)
		aV := int32(3)
		current := collector.Collector{
			ActiveVersion: 1,
			LatestVersion: 10,
		}
		params := UpdateParams{
			JobID:           uuid.New(),
			ActiveVersion:   &aV,
			MinCleanVersion: &minCleanV,
			MinTextVersion:  &minTextV,
			Fields: &map[string]uuid.UUID{
				"example_key": uuid.New(),
			},
		}

		pool.ExpectQuery("name: AllQueriesExist :one").WithArgs(database.MustToDBUUIDArray([]uuid.UUID{(*params.Fields)["example_key"]})).WillReturnRows(
			pgxmock.NewRows([]string{"all_exist"}).
				AddRow(true),
		)

		dbparams, err := svc.getUpdateParams(ctx, &current, &params)
		assert.NoError(t, err)
		assert.EqualExportedValues(t, &dbUpdateParams{
			JobID:           database.MustToDBUUID(params.JobID),
			ActiveVersion:   &aV,
			MinCleanVersion: &minCleanV,
			MinTextVersion:  &minTextV,
			Fields: &map[string]pgtype.UUID{
				"example_key": database.MustToDBUUID((*params.Fields)["example_key"]),
			},
		}, dbparams)

		(*params.Fields)["second_key"] = (*params.Fields)["example_key"]
		assert.Len(t, *params.Fields, 2)
		_, err = svc.getUpdateParams(ctx, &current, &params)
		assert.Error(t, err)
	})

	t.Run("no params", func(t *testing.T) {
		ctx := context.Background()

		pool, err := pgxmock.NewPool()
		if err != nil {
			t.Fatalf("failed to open pgxmock database: %v", err)
		}
		cfg := &CollectorUpdateConfig{}
		cfg.DBPool = pool
		cfg.DBQueries = repository.New(pool)

		svc := Service{
			cfg: cfg,
			svc: &Services{},
		}

		current := collector.Collector{}
		params := UpdateParams{
			JobID: current.JobID,
		}
		_, err = svc.getUpdateParams(ctx, &current, &params)
		assert.EqualError(t, err, "no changes")
	})

	t.Run("ONLY active version to next latest", func(t *testing.T) {
		ctx := context.Background()

		pool, err := pgxmock.NewPool()
		if err != nil {
			t.Fatalf("failed to open pgxmock database: %v", err)
		}
		cfg := &CollectorUpdateConfig{}
		cfg.DBPool = pool
		cfg.DBQueries = repository.New(pool)

		svc := Service{
			cfg: cfg,
			svc: &Services{},
		}

		current := collector.Collector{
			ActiveVersion: 2,
			LatestVersion: 4,
		}
		version := int32(5)
		params := UpdateParams{
			JobID:         current.JobID,
			ActiveVersion: &version,
		}
		_, err = svc.getUpdateParams(ctx, &current, &params)
		assert.EqualError(t, err, "no changes")
	})

	t.Run("no fields change", func(t *testing.T) {
		ctx := context.Background()

		pool, err := pgxmock.NewPool()
		if err != nil {
			t.Fatalf("failed to open pgxmock database: %v", err)
		}
		cfg := &CollectorUpdateConfig{}
		cfg.DBPool = pool
		cfg.DBQueries = repository.New(pool)

		svc := Service{
			cfg: cfg,
			svc: &Services{},
		}

		current := collector.Collector{
			Fields: map[string]uuid.UUID{
				"example": uuid.New(),
			},
		}
		params := UpdateParams{
			JobID: current.JobID,
			Fields: &map[string]uuid.UUID{
				"example": current.Fields["example"],
			},
		}
		_, err = svc.getUpdateParams(ctx, &current, &params)
		assert.EqualError(t, err, "no changes")
	})
}

func TestSubmitUpdate(t *testing.T) {
	t.Run("all fields", func(t *testing.T) {

		ctx := context.Background()

		pool, err := pgxmock.NewPool()
		if err != nil {
			t.Fatalf("failed to open pgxmock database: %v", err)
		}
		cfg := &CollectorUpdateConfig{}
		cfg.DBPool = pool
		cfg.DBQueries = repository.New(pool)

		svc := Service{
			cfg: cfg,
			svc: &Services{},
		}

		minCleanV := int32(2)
		minTextV := int32(4)
		current := collector.Collector{
			JobID:           uuid.New(),
			ActiveVersion:   1,
			LatestVersion:   1,
			MinCleanVersion: 1,
			MinTextVersion:  2,
			Fields: map[string]uuid.UUID{
				"original_key": uuid.New(),
				"og_key":       uuid.New(),
			},
		}
		aV := int32(2)
		params := dbUpdateParams{
			JobID:           database.MustToDBUUID(current.JobID),
			ActiveVersion:   &aV,
			MinCleanVersion: &minCleanV,
			MinTextVersion:  &minTextV,
			Fields: &map[string]pgtype.UUID{
				"example_key": database.MustToDBUUID(uuid.New()),
				"second_key":  database.MustToDBUUID(uuid.New()),
				"changed_key": database.MustToDBUUID(current.Fields["original_key"]),
				"og_key":      database.MustToDBUUID(current.Fields["og_key"]),
			},
		}

		pool.ExpectBeginTx(pgx.TxOptions{})
		rv := int32(2)
		pool.ExpectQuery("name: AddLatestCollectorVersion :one").WithArgs(database.MustToDBUUID(current.JobID)).WillReturnRows(
			pgxmock.NewRows([]string{"version"}).
				AddRow(rv),
		)
		pool.ExpectExec("name: SetActiveCollectorVersion :exec").WithArgs(database.MustToDBUUID(current.JobID), int32(2)).
			WillReturnResult(pgxmock.NewResult("", 1))
		pool.ExpectExec("name: SetCollectorCleanVersion :exec").WithArgs(database.MustToDBUUID(current.JobID), rv, *params.MinCleanVersion).
			WillReturnResult(pgxmock.NewResult("", 1))
		pool.ExpectExec("name: SetCollectorTextVersion :exec").WithArgs(database.MustToDBUUID(current.JobID), rv, *params.MinTextVersion).
			WillReturnResult(pgxmock.NewResult("", 1))
		pool.ExpectExec("name: RemoveCollectorQuery :exec").WithArgs(&rv, database.MustToDBUUID(current.Fields["original_key"]), database.MustToDBUUID(current.JobID)).
			WillReturnResult(pgxmock.NewResult("", 1))
		pool.MatchExpectationsInOrder(false)
		pool.ExpectExec("name: AddCollectorQuery :exec").WithArgs(database.MustToDBUUID(current.JobID), "example_key", (*params.Fields)["example_key"], int32(2)).
			WillReturnResult(pgxmock.NewResult("", 1))
		pool.ExpectExec("name: AddCollectorQuery :exec").WithArgs(database.MustToDBUUID(current.JobID), "second_key", (*params.Fields)["second_key"], int32(2)).
			WillReturnResult(pgxmock.NewResult("", 1))
		pool.ExpectExec("name: AddCollectorQuery :exec").WithArgs(database.MustToDBUUID(current.JobID), "changed_key", (*params.Fields)["changed_key"], int32(2)).
			WillReturnResult(pgxmock.NewResult("", 1))
		pool.ExpectCommit()

		err = svc.submitUpdate(ctx, &current, &params)
		assert.NoError(t, err)
	})
	t.Run("only active version", func(t *testing.T) {

		ctx := context.Background()

		pool, err := pgxmock.NewPool()
		if err != nil {
			t.Fatalf("failed to open pgxmock database: %v", err)
		}
		cfg := &CollectorUpdateConfig{}
		cfg.DBPool = pool
		cfg.DBQueries = repository.New(pool)

		svc := Service{
			cfg: cfg,
			svc: &Services{},
		}

		current := collector.Collector{
			JobID:           uuid.New(),
			ActiveVersion:   1,
			LatestVersion:   1,
			MinCleanVersion: 1,
			MinTextVersion:  2,
			Fields:          map[string]uuid.UUID{},
		}
		av := int32(2)
		params := dbUpdateParams{
			JobID:         database.MustToDBUUID(current.JobID),
			ActiveVersion: &av,
		}

		pool.ExpectBeginTx(pgx.TxOptions{})
		pool.ExpectExec("name: SetActiveCollectorVersion :exec").WithArgs(database.MustToDBUUID(current.JobID), int32(2)).
			WillReturnResult(pgxmock.NewResult("", 1))
		pool.ExpectCommit()

		err = svc.submitUpdate(ctx, &current, &params)
		assert.NoError(t, err)
	})
}

func TestNormalizeActiveVersion(t *testing.T) {
	svc := Service{}

	t.Run("all nil", func(t *testing.T) {
		err := svc.normalizeActiveVersion(nil, nil)
		assert.Error(t, err)
	})

	t.Run("nil update", func(t *testing.T) {
		current := collector.Collector{
			ActiveVersion: 1,
			LatestVersion: 4,
		}

		err := svc.normalizeActiveVersion(&current, nil)
		assert.NoError(t, err)
	})

	t.Run("no update", func(t *testing.T) {
		current := collector.Collector{
			ActiveVersion: 1,
			LatestVersion: 4,
		}
		update := UpdateParams{}
		err := svc.normalizeActiveVersion(&current, &update)
		assert.NoError(t, err)
		assert.Nil(t, update.ActiveVersion)
	})

	t.Run("same version", func(t *testing.T) {
		version := int32(2)
		current := collector.Collector{
			ActiveVersion: version,
			LatestVersion: 4,
		}
		update := UpdateParams{
			ActiveVersion: &version,
		}
		err := svc.normalizeActiveVersion(&current, &update)
		assert.NoError(t, err)
		assert.Nil(t, update.ActiveVersion)
	})

	t.Run("latest version plus 1", func(t *testing.T) {
		current := collector.Collector{
			ActiveVersion: 1,
			LatestVersion: 4,
		}
		version := int32(5)
		update := UpdateParams{
			ActiveVersion: &version,
		}
		err := svc.normalizeActiveVersion(&current, &update)
		assert.NoError(t, err)
		assert.Equal(t, version, *update.ActiveVersion)
	})

	t.Run("latest version plus 2", func(t *testing.T) {
		current := collector.Collector{
			ActiveVersion: 1,
			LatestVersion: 4,
		}
		version := int32(6)
		update := UpdateParams{
			ActiveVersion: &version,
		}
		err := svc.normalizeActiveVersion(&current, &update)
		assert.Error(t, err)
	})
}

func TestNormalizeCodeVersions(t *testing.T) {
	cfg := &CollectorUpdateConfig{}
	svc := Service{
		svc: &Services{
			CleanVersion: cleanversion.New(cfg),
			TextVersion:  textversion.New(cfg),
		},
	}

	t.Run("all nil", func(t *testing.T) {
		err := svc.normalizeCodeVersions(nil, nil)
		assert.Error(t, err)
	})

	t.Run("nil update", func(t *testing.T) {
		current := collector.Collector{}
		err := svc.normalizeCodeVersions(&current, nil)
		assert.NoError(t, err)
	})

	t.Run("empty", func(t *testing.T) {
		current := collector.Collector{}
		update := UpdateParams{}

		err := svc.normalizeCodeVersions(&current, &update)
		assert.NoError(t, err)
		assert.Nil(t, update.MinCleanVersion)
		assert.Nil(t, update.MinTextVersion)
	})

	t.Run("valid clean", func(t *testing.T) {
		current := collector.Collector{}
		update := UpdateParams{}

		cv := int32(1)
		update.MinCleanVersion = &cv
		err := svc.normalizeCodeVersions(&current, &update)
		assert.NoError(t, err)
		assert.Equal(t, cv, *update.MinCleanVersion)
		assert.Nil(t, update.MinTextVersion)
	})

	t.Run("valid text", func(t *testing.T) {
		current := collector.Collector{}
		update := UpdateParams{}

		tv := int32(1)
		update.MinTextVersion = &tv
		err := svc.normalizeCodeVersions(&current, &update)
		assert.NoError(t, err)
		assert.Nil(t, update.MinCleanVersion)
		assert.Equal(t, tv, *update.MinTextVersion)
	})

	t.Run("valid clean and text", func(t *testing.T) {
		current := collector.Collector{}
		update := UpdateParams{}

		current.MinCleanVersion = 1
		current.MinTextVersion = 1
		err := svc.normalizeCodeVersions(&current, &update)
		assert.NoError(t, err)
		assert.Nil(t, update.MinCleanVersion)
		assert.Nil(t, update.MinTextVersion)
	})

	t.Run("current clean", func(t *testing.T) {
		current := collector.Collector{
			MinCleanVersion: 1,
		}
		update := UpdateParams{}

		update.MinCleanVersion = &current.MinCleanVersion
		err := svc.normalizeCodeVersions(&current, &update)
		assert.NoError(t, err)
		assert.Nil(t, update.MinCleanVersion)
		assert.Nil(t, update.MinTextVersion)
	})

	t.Run("current text", func(t *testing.T) {
		current := collector.Collector{
			MinTextVersion: 1,
		}
		update := UpdateParams{}

		update.MinTextVersion = &current.MinTextVersion
		err := svc.normalizeCodeVersions(&current, &update)
		assert.NoError(t, err)
		assert.Nil(t, update.MinCleanVersion)
		assert.Nil(t, update.MinTextVersion)
	})

	t.Run("current clean and text", func(t *testing.T) {
		current := collector.Collector{
			MinCleanVersion: 1,
			MinTextVersion:  1,
		}
		update := UpdateParams{}

		update.MinCleanVersion = &current.MinCleanVersion
		update.MinTextVersion = &current.MinTextVersion
		err := svc.normalizeCodeVersions(&current, &update)
		assert.NoError(t, err)
		assert.Nil(t, update.MinCleanVersion)
		assert.Nil(t, update.MinTextVersion)
	})
}

func TestGetRemoveFields(t *testing.T) {
	current := map[string]uuid.UUID{}
	var update *map[string]pgtype.UUID

	remove := getRemoveFields(current, update)
	assert.Len(t, remove, 0)

	current["a"] = uuid.New()
	remove = getRemoveFields(current, update)
	assert.Len(t, remove, 0)

	update = &map[string]pgtype.UUID{
		"b": database.MustToDBUUID(uuid.New()),
	}

	(*update)["a"] = database.MustToDBUUID(current["a"])
	remove = getRemoveFields(current, update)
	assert.Len(t, remove, 0)

	(*update)["a"] = database.MustToDBUUID(uuid.New())
	remove = getRemoveFields(current, update)
	assert.Len(t, remove, 1)
	assert.ElementsMatch(t, []pgtype.UUID{database.MustToDBUUID(current["a"])}, remove)

	(*update)["a"] = database.MustToDBUUID(uuid.Nil)
	(*update)["c"] = database.MustToDBUUID(current["a"])
	remove = getRemoveFields(current, update)
	assert.Len(t, remove, 1)
	assert.ElementsMatch(t, []pgtype.UUID{database.MustToDBUUID(current["a"])}, remove)
}

func TestGetAddFields(t *testing.T) {
	current := map[string]uuid.UUID{}
	var update *map[string]pgtype.UUID

	add := getAddFields(current, update)
	assert.Len(t, add, 0)

	current["a"] = uuid.New()
	add = getAddFields(current, update)
	assert.Len(t, add, 0)

	update = &map[string]pgtype.UUID{}

	add = getAddFields(current, update)
	assert.Len(t, add, 0)

	(*update)["a"] = database.MustToDBUUID(current["a"])
	add = getAddFields(current, update)
	assert.Len(t, add, 0)

	(*update)["a"] = database.MustToDBUUID(uuid.New())
	add = getAddFields(current, update)
	assert.Len(t, add, 1)
	assert.Equal(t, map[string]pgtype.UUID{
		"a": (*update)["a"],
	}, add)

	(*update)["a"] = database.MustToDBUUID(current["a"])
	(*update)["b"] = database.MustToDBUUID(uuid.New())
	add = getAddFields(current, update)
	assert.Len(t, add, 1)
	assert.Equal(t, map[string]pgtype.UUID{
		"b": (*update)["b"],
	}, add)

	current = map[string]uuid.UUID{}
	add = getAddFields(current, update)
	assert.Len(t, add, 2)
	assert.Equal(t, map[string]pgtype.UUID{
		"b": (*update)["b"],
		"a": (*update)["a"],
	}, add)
}

func TestNormalizeUpdateFieldsToDB(t *testing.T) {
	t.Run("valid key", func(t *testing.T) {

		ctx := context.Background()

		pool, err := pgxmock.NewPool()
		if err != nil {
			t.Fatalf("failed to open pgxmock database: %v", err)
		}
		cfg := &CollectorUpdateConfig{}
		cfg.DBPool = pool
		cfg.DBQueries = repository.New(pool)

		svc := Service{
			cfg: cfg,
			svc: &Services{
				Collector: collector.New(cfg, &collector.Services{}),
			},
		}

		current := map[string]uuid.UUID{}
		fields := map[string]uuid.UUID{
			"example_key": uuid.New(),
		}

		pool.ExpectQuery("name: AllQueriesExist :one").WithArgs(database.MustToDBUUIDArray([]uuid.UUID{fields["example_key"]})).WillReturnRows(
			pgxmock.NewRows([]string{"all_exist"}).
				AddRow(true),
		)

		dbparams, err := svc.normalizeUpdateFieldsToDB(ctx, current, &fields)
		assert.NoError(t, err)
		assert.EqualExportedValues(t, &map[string]pgtype.UUID{
			"example_key": database.MustToDBUUID(fields["example_key"]),
		}, dbparams)
	})

	t.Run("duplicate values", func(t *testing.T) {
		ctx := context.Background()

		pool, err := pgxmock.NewPool()
		if err != nil {
			t.Fatalf("failed to open pgxmock database: %v", err)
		}
		cfg := &CollectorUpdateConfig{}
		cfg.DBPool = pool
		cfg.DBQueries = repository.New(pool)

		svc := Service{
			cfg: cfg,
			svc: &Services{},
		}

		current := map[string]uuid.UUID{}
		fields := map[string]uuid.UUID{
			"example_key": uuid.New(),
		}
		fields["second_key"] = fields["example_key"]

		pool.ExpectQuery("name: AllQueriesExist :one").WithArgs(database.MustToDBUUIDArray([]uuid.UUID{fields["example_key"]})).WillReturnRows(
			pgxmock.NewRows([]string{"all_exist"}).
				AddRow(true),
		)

		_, err = svc.normalizeUpdateFieldsToDB(ctx, current, &fields)
		assert.Error(t, err)
	})
	t.Run("no changes", func(t *testing.T) {
		ctx := context.Background()
		cfg := &CollectorUpdateConfig{}

		svc := Service{
			cfg: cfg,
			svc: &Services{
				Collector: collector.New(cfg, &collector.Services{}),
			},
		}

		current := map[string]uuid.UUID{
			"example_key": uuid.New(),
		}
		fields := map[string]uuid.UUID{
			"example_key": current["example_key"],
		}

		val, err := svc.normalizeUpdateFieldsToDB(ctx, current, &fields)
		assert.NoError(t, err)
		assert.Nil(t, val)
	})
}

func TestInformUpdate(t *testing.T) {
	t.Run("with version update", func(t *testing.T) {
		ctx := context.Background()

		pool, err := pgxmock.NewPool()
		if err != nil {
			t.Fatalf("failed to open pgxmock database: %v", err)
		}
		cfg := &CollectorUpdateConfig{}
		cfg.DBPool = pool
		cfg.DBQueries = repository.New(pool)
		mockSQS := queuemock.NewMockSQSClient(t)
		cfg.QueueClient = mockSQS
		cfg.JobSyncURL = "here"

		svc := New(cfg, &Services{})

		av := int32(2)
		update := dbUpdateParams{
			JobID:         database.MustToDBUUID(uuid.New()),
			ActiveVersion: &av,
		}

		mockSQS.EXPECT().
			SendMessage(
				mock.Anything,
				mock.MatchedBy(func(in *sqs.SendMessageInput) bool {
					return *in.QueueUrl == cfg.JobSyncURL && *in.MessageBody == fmt.Sprintf("{\"id\":\"%s\"}", update.JobID.String())
				}),
				mock.Anything,
			).
			Return(&sqs.SendMessageOutput{}, nil)

		err = svc.informUpdate(ctx, &update)
		assert.NoError(t, err)
	})
	t.Run("with no update", func(t *testing.T) {
		ctx := context.Background()

		pool, err := pgxmock.NewPool()
		if err != nil {
			t.Fatalf("failed to open pgxmock database: %v", err)
		}
		cfg := &CollectorUpdateConfig{}
		cfg.DBPool = pool
		cfg.DBQueries = repository.New(pool)
		mockSQS := queuemock.NewMockSQSClient(t)
		cfg.QueueClient = mockSQS
		cfg.JobSyncURL = "here"

		svc := New(cfg, &Services{})

		update := dbUpdateParams{
			JobID: database.MustToDBUUID(uuid.New()),
		}

		err = svc.informUpdate(ctx, &update)
		assert.NoError(t, err)
	})
}