docs: update PRD - Phase 3 now 100% complete
- Updated progress table: Phase 3 is now 100% complete
- Marked code_funcs.py as complete (commit a7a32b90)
- Updated remaining work section
- Added latest commit to commit history
This commit is contained in:
@@ -10,18 +10,20 @@
|
||||
|
||||
## Implementation Progress
|
||||
|
||||
**Overall Status**: 🟢 **Phase 3 of 6 Mostly Complete** (Foundation + Templates + Calling Layer)
|
||||
**Overall Status**: 🟢 **Phase 3 of 6 Complete** (Foundation + Templates + Calling Layer)
|
||||
|
||||
| Phase | Status | Completion | Details |
|
||||
|-------|--------|------------|---------|
|
||||
| Phase 1: Foundation | ✅ Complete | 100% | JSON parsers, deprecation warnings, unit tests |
|
||||
| Phase 2: Prompt Templates | ✅ Complete | 100% | All 35 templates return (prompt, parser) tuples |
|
||||
| Phase 3: Prompt Calling Layer | ✅ Mostly Complete | 95% | All prompt_calls.py updated; 2 remaining in code_funcs.py |
|
||||
| Phase 3: Prompt Calling Layer | ✅ Complete | 100% | All prompt_calls.py updated; code_funcs.py fixed |
|
||||
| Phase 4: Downstream Consumers | 🟡 Partially Complete | 60% | Most files updated; aarete_derived.py has dual-format support |
|
||||
| Phase 5: Testing | 🔲 Not Started | 0% | Integration tests, golden tests |
|
||||
| Phase 6: Cleanup & Documentation | 🔲 Not Started | 0% | Remove backward compat, docs |
|
||||
|
||||
**Latest Commits** (after PRD update):
|
||||
- `a7a32b90` - Completed Phase 3: Fixed remaining universal_json_load calls in code_funcs.py
|
||||
- `2e307347` - Updated investment_prompts.json to use JSON format instead of pipes
|
||||
- `df103579` - Updated postprocessing_funcs.py
|
||||
- `0d9f9314` - Updated tin_npi_funcs.py and page_funcs.py
|
||||
- `8399dbdf` - Updated crosswalk reverse mapping
|
||||
@@ -31,7 +33,7 @@
|
||||
- `5d1024e` - Updated prompt instruction functions with JSON format instructions
|
||||
|
||||
**Remaining Work**:
|
||||
- **Phase 3**: 2 remaining `universal_json_load` calls in `code_funcs.py` (lines 498, 856)
|
||||
- **Phase 3**: ✅ **COMPLETE** - All `universal_json_load` calls replaced (Commit: a7a32b90)
|
||||
- **Phase 4**: `aarete_derived.py` has dual-format support (handles both JSON lists and pipe-delimited) - may be intentional for backward compatibility
|
||||
|
||||
---
|
||||
@@ -2789,10 +2791,11 @@ def test_parsing_performance():
|
||||
- [x] All functions updated to use tuple unpacking pattern (25 instances)
|
||||
- [x] Update `src/pipelines/clients/bcbs_promise/prompts/prompt_calls.py` ✅ **COMPLETE** (Commit: dba61146)
|
||||
- [x] All functions updated to use tuple unpacking pattern (25 instances)
|
||||
- [ ] Update `src/codes/code_funcs.py` ⚠️ **PARTIAL** (2 remaining calls)
|
||||
- [x] Update `src/codes/code_funcs.py` ✅ **COMPLETE** (Commit: a7a32b90)
|
||||
- [x] Most functions updated (Commit: 6c3f3f6f)
|
||||
- [ ] Line 498: `string_utils.universal_json_load(llm_answer_raw)` - Still needs update
|
||||
- [ ] Line 856: `string_utils.universal_json_load(claude_answer_raw)` - Still needs update
|
||||
- [x] Line 498: Changed to use `_parser` from FILL_BILL_TYPE tuple
|
||||
- [x] Line 856: Changed to use `grouper_parser` from GROUPER_BREAKOUT tuple
|
||||
- [x] Removed unused `GROUPER_QUESTIONS` variable
|
||||
- [x] Update `src/pipelines/shared/extraction/tin_npi_funcs.py` ✅ **COMPLETE** (Commit: 0d9f9314)
|
||||
- [x] All `universal_json_load` calls replaced
|
||||
- [x] Update `src/pipelines/shared/preprocessing/hybrid_smart_chunking_funcs.py` ✅ **COMPLETE** (Commit: dba61146)
|
||||
|
||||
Reference in New Issue
Block a user